Move pip install to dedicated GitHub Actions steps by Copilot · Pull Request #206 · SemiAnalysisAI/InferenceX

Copilot · 2025-11-09T22:10:04Z

Inline pip install commands in workflow run scripts should be moved to proper GitHub Actions steps for better organization and maintainability.

Changes

Removed inline pip install: Eliminated subprocess.run(['pip', 'install', 'pydantic']) and bash script pip commands from 8 workflow files
Added Python setup steps: Each job now includes actions/setup-python@v6 with Python 3.12 before dependency installation
Standardized pattern: All workflows use dedicated "Install dependencies" steps with only the packages they need
Optimized dependencies: Each workflow installs only required packages (e.g., label-validation.yml installs only pydantic, not pyyaml)
Preserved original behavior: Maintained the -q flag for quiet matplotlib installation in collect-results.yml

Example

Before:

- id: get-jobs
  run: |
    pip install pydantic
    CONFIG_JSON=$(python3 generate_sweep_configs.py)

After:

- name: Set up Python
  uses: actions/setup-python@v6
  with:
    python-version: '3.12'

- name: Install dependencies
  run: pip install pydantic pyyaml

- id: get-jobs
  run: |
    CONFIG_JSON=$(python3 generate_sweep_configs.py)

Files Modified

.github/workflows/e2e-tests.yml
.github/workflows/full-sweep-{1k1k,1k8k,8k1k}-scheduler.yml
.github/workflows/full-sweep-test.yml
.github/workflows/collect-results.yml
.github/workflows/label-validation.yml
.github/workflows/test-matrix-logic.yml

View original Slack conversation

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: functionstackx <47992694+functionstackx@users.noreply.github.com>

Copilot

Pull Request Overview

This PR improves GitHub Actions workflow efficiency by moving inline pip install commands into dedicated dependency installation steps with caching enabled. This allows GitHub Actions to cache Python packages between runs, reducing build times and network usage.

Key changes:

Added actions/setup-python@v6 with cache: 'pip' configuration to 8 workflow files
Removed inline pip install commands from bash scripts and Python subprocess calls
Created requirements-workflows.txt to centralize workflow dependencies

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`requirements-workflows.txt`	New file documenting all Python dependencies used across workflows
`.github/workflows/test-matrix-logic.yml`	Added pip caching to existing Python setup step
`.github/workflows/label-validation.yml`	Added Python setup with caching and removed inline pip installs from two jobs
`.github/workflows/full-sweep-test.yml`	Added Python setup with caching and removed inline pip installs from config generation and results collection jobs
`.github/workflows/full-sweep-8k1k-scheduler.yml`	Added Python setup with caching to three jobs (dsr1, gptoss config generation, and results collection)
`.github/workflows/full-sweep-1k8k-scheduler.yml`	Added Python setup with caching to three jobs (dsr1, gptoss config generation, and results collection)
`.github/workflows/full-sweep-1k1k-scheduler.yml`	Added Python setup with caching to three jobs (dsr1, gptoss config generation, and results collection)
`.github/workflows/e2e-tests.yml`	Added Python setup with caching and removed inline pip installs from job generation and results collection
`.github/workflows/collect-results.yml`	Added Python setup with caching and simplified plot performance step

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-09T22:49:00Z

+# Requirements for GitHub Actions workflows
+# Used by various workflow files to generate configs and process results
+pydantic>=2.0.0
+pyyaml>=6.0.0
+PyGithub>=2.0.0
+matplotlib>=3.0.0
+pytest>=7.0.0


The requirements-workflows.txt file is not referenced by any of the workflow files. The workflows install dependencies directly via pip install <package> commands instead of using pip install -r requirements-workflows.txt. Either update the workflows to use this requirements file, or remove it if it's intended only as documentation.

Suggested change

# Requirements for GitHub Actions workflows

# Used by various workflow files to generate configs and process results

pydantic>=2.0.0

pyyaml>=6.0.0

PyGithub>=2.0.0

matplotlib>=3.0.0

pytest>=7.0.0

Removed requirements-workflows.txt as workflows install dependencies directly. (4dd647e)

Copilot · 2025-11-09T22:49:01Z

+          cache: 'pip'
+
+      - name: Install dependencies
+        run: pip install pydantic pyyaml


The workflow installs pydantic and pyyaml but the Python script only imports subprocess, json, and os. The pydantic dependency was previously installed inline before calling generate_sweep_configs.py as a subprocess, which still requires it. However, pyyaml doesn't appear to be needed in this job. Consider installing only the dependencies required by the subprocess call.

Suggested change

run: pip install pydantic pyyaml

run: pip install pydantic

Fixed to install only pydantic (removed pyyaml). (4dd647e)

Copilot · 2025-11-09T22:49:01Z

+          cache: 'pip'
+
+      - name: Install dependencies
+        run: pip install matplotlib


[nitpick] The previous version used pip install -q matplotlib with the -q (quiet) flag to reduce output verbosity. Consider retaining this flag for consistency with the original behavior and cleaner logs.

Suggested change

run: pip install matplotlib

run: pip install -q matplotlib

Restored the -q flag for quiet output. (4dd647e)

functionstackx · 2025-11-09T22:55:45Z

@copilot Error: No file in /home/runner/work/InferenceMAX/InferenceMAX matched to [**/requirements.txt or **/pyproject.toml], make sure you have checked out the target repository

Co-authored-by: functionstackx <47992694+functionstackx@users.noreply.github.com>

Copilot · 2025-11-09T23:02:14Z

@copilot Error: No file in /home/runner/work/InferenceMAX/InferenceMAX matched to [**/requirements.txt or **/pyproject.toml], make sure you have checked out the target repository

Removed cache: 'pip' from all workflows as it requires a requirements.txt or pyproject.toml file in the repository root. The workflows now use Python setup without caching. (4dd647e)

cquil11

Seems reasonable

This reverts commit b1df040.

) This reverts commit b1df040.

Copilot AI assigned Copilot and functionstackx Nov 9, 2025

Copilot started work on behalf of functionstackx November 9, 2025 22:10 View session

Copilot AI changed the title ~~[WIP] Update GitHub Action to install pydantic using caching~~ Move pip install to dedicated GitHub Actions steps with caching Nov 9, 2025

Copilot finished work on behalf of functionstackx November 9, 2025 22:25

Copilot AI requested a review from functionstackx November 9, 2025 22:25

Refactor pip install to use GitHub Actions steps with Python caching

6fd5041

Co-authored-by: functionstackx <47992694+functionstackx@users.noreply.github.com>

functionstackx force-pushed the copilot/update-github-action-workflow branch from 0f30308 to 6fd5041 Compare November 9, 2025 22:48

functionstackx marked this pull request as ready for review November 9, 2025 22:48

functionstackx requested a review from a team as a code owner November 9, 2025 22:48

Copilot AI review requested due to automatic review settings November 9, 2025 22:48

functionstackx added the h100_gptoss label Nov 9, 2025

Copilot AI reviewed Nov 9, 2025

View reviewed changes

Copilot started work on behalf of functionstackx November 9, 2025 22:56 View session

Remove cache: 'pip', fix dependencies, and restore -q flag

4dd647e

Co-authored-by: functionstackx <47992694+functionstackx@users.noreply.github.com>

Copilot AI changed the title ~~Move pip install to dedicated GitHub Actions steps with caching~~ Move pip install to dedicated GitHub Actions steps Nov 9, 2025

Copilot finished work on behalf of functionstackx November 9, 2025 23:04

functionstackx added h100_gptoss and removed h100_gptoss labels Nov 9, 2025

cquil11 approved these changes Nov 10, 2025

View reviewed changes

cquil11 added 2 commits November 10, 2025 09:33

Merge branch 'main' into copilot/update-github-action-workflow

108c7c4

add pyyaml install to label validation workflow

449a9f2

cquil11 merged commit b1df040 into main Nov 10, 2025
4 checks passed

cquil11 deleted the copilot/update-github-action-workflow branch November 10, 2025 17:01

functionstackx added a commit that referenced this pull request Nov 10, 2025

Revert "Move pip install to dedicated GitHub Actions steps (#206)"

03a3975

This reverts commit b1df040.

functionstackx mentioned this pull request Nov 10, 2025

Revert "Move pip install to dedicated GitHub Actions steps" #219

Merged

functionstackx added a commit that referenced this pull request Nov 10, 2025

Revert "Move pip install to dedicated GitHub Actions steps (#206)" (#219

167b724

) This reverts commit b1df040.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move pip install to dedicated GitHub Actions steps#206

Move pip install to dedicated GitHub Actions steps#206
cquil11 merged 4 commits into
mainfrom
copilot/update-github-action-workflow

Copilot AI commented Nov 9, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 9, 2025

Uh oh!

Copilot AI Nov 9, 2025

Uh oh!

Copilot AI Nov 9, 2025

Uh oh!

Copilot AI Nov 9, 2025

Uh oh!

Copilot AI Nov 9, 2025

Uh oh!

Copilot AI Nov 9, 2025

Uh oh!

functionstackx commented Nov 9, 2025

Uh oh!

Copilot AI commented Nov 9, 2025

Uh oh!

cquil11 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Copilot AI commented Nov 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Example

Files Modified

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 9, 2025

Choose a reason for hiding this comment

Uh oh!

functionstackx commented Nov 9, 2025

Uh oh!

Copilot AI commented Nov 9, 2025

Uh oh!

cquil11 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Nov 9, 2025 •

edited

Loading